-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: menu item suffix #1427
feat: menu item suffix #1427
Conversation
🚀 Deployed on https://pr-1427--dhis2-ui.netlify.app |
Passing run #3125 ↗︎
Details:
Review all test suite changes for PR #1427 ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a functional perspective this looks good! Could you add a story with both the chevron and the suffix? That way it's clear that both can be used together and we can see what it looks like, too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! LGTM
Implements LIBS-536
Description
This PR adds the optional
suffix
prop to<MenuItem>
. Asuffix
is displayed at the end of the component. Asuffix
can be used alongsidechevron: true
.Checklist
All points above should be relevant for feature PRs. For bugfixes, some points might not be relevant. In that case, just check them anyway to signal the work is done.
Screenshots